Honour expose property of http-errors #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: getsnoopy <[email protected]>
This commit adds support for the "expose" property used by the http-errors module, which allows developers to explicitly signal the error message to be passed to the HTTP response for errors. This is useful for certain errors (e.g., those with status code >=500) where the original error message is otherwise suppressed by default. Resolves: loopbackio#78 Signed-off-by: getsnoopy <[email protected]>
2 tasks
dhmlau
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
@getsnoopy, thanks for your contribution. Your changes LGTM.
However, I haven't been able to rebase your branch, so I've created PR #594 and add your authorship in there.
|
Closing in favor of PR #594. |
github-project-automation
bot
moved this from Icebox
to Done
in LoopBack Common Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for the
exposeproperty used by thehttp-errorsmodule, which allows developers to explicitly signal theerror message to be passed to the HTTP response for errors. This is
useful for certain errors (e.g., those with status code >=
500) where theoriginal error message is otherwise suppressed by default.
Related issues
exposeproperty of http-errors #78Checklist
guide